<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109281/">http://git.reviewboard.kde.org/r/109281/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 6th, 2013, 3:32 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this change deliberate?
-X-KTp-PluginInfo-Version=
+X-KDE-PluginInfo-Version=
NOTE KTp -> KDE
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, I'm stupid... I'm fixing this in a minute</pre>
<br />
<p>- Daniele E.</p>
<br />
<p>On March 5th, 2013, 7:17 p.m. UTC, Daniele E. Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Daniele E. Domenichelli.</div>
<p style="color: grey;"><i>Updated March 5, 2013, 7:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use KTP_TEXT_UI_VERSION for plugin version, and get X-KTp-PluginInfo-Version from CMake
Since we are not using the version properly, I suggest that we use ktp-text-ui version for all plugins.
Also by using cmake to set X-KTp-PluginInfo-Version, we can update all of them just by changing one value</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(3cef67d54511410fa49135b453d91a6251a8db36)</span></li>
<li>filters/emoticons/CMakeLists.txt <span style="color: grey">(5054e8d1affbc4e52b633059dfad8f824e563923)</span></li>
<li>filters/emoticons/ktptextui_message_filter_emoticons.desktop <span style="color: grey">(27968ecef73fe0e4688406850e8e5ef713c8f945)</span></li>
<li>filters/emoticons/ktptextui_message_filter_emoticons.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/formatting/CMakeLists.txt <span style="color: grey">(1bb818c5e074da7c620387671be220dc4e53cb42)</span></li>
<li>filters/formatting/ktptextui_message_filter_formatting.desktop <span style="color: grey">(cccb3817612a16602a3b0e9a0914c0f3873bc01a)</span></li>
<li>filters/formatting/ktptextui_message_filter_formatting.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/highlight/CMakeLists.txt <span style="color: grey">(3d6df3ae0ce78bcc2da758261d55e88dcb2d5f4a)</span></li>
<li>filters/highlight/ktptextui_message_filter_highlight.desktop <span style="color: grey">(8ce122e2a980ae0ae30686850e7dfd79a5e49f3c)</span></li>
<li>filters/highlight/ktptextui_message_filter_highlight.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/images/CMakeLists.txt <span style="color: grey">(33bdbc9f64beeea9d1b2ac13f5c2d1d4f9d01b1f)</span></li>
<li>filters/images/ktptextui_message_filter_images.desktop <span style="color: grey">(1282258dc79aad459802ae392315db9609471aff)</span></li>
<li>filters/images/ktptextui_message_filter_images.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/searchexpansion/CMakeLists.txt <span style="color: grey">(2b6c95d9505e4ebc87c0a96b5ca95766ec0ec5d0)</span></li>
<li>filters/searchexpansion/ktptextui_message_filter_searchexpansion.desktop <span style="color: grey">(0597f14191cac2c6a54ebfb109b88435a85c7ccc)</span></li>
<li>filters/searchexpansion/ktptextui_message_filter_searchexpansion.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/texttospeech/CMakeLists.txt <span style="color: grey">(8f2569670377942bfa37f3c4777864f5c9fcc100)</span></li>
<li>filters/texttospeech/ktptextui_message_filter_tts.desktop <span style="color: grey">(ffb8d93b888ad6b008c726b15a130e9537ab34d8)</span></li>
<li>filters/texttospeech/ktptextui_message_filter_tts.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/youtube/CMakeLists.txt <span style="color: grey">(3d4eb5ae2959ea984898e2e9f0279821bc27d940)</span></li>
<li>filters/youtube/ktptextui_message_filter_youtube.desktop <span style="color: grey">(8a2572f41bcbf475b8fe379bf80b4c2cc494ac12)</span></li>
<li>filters/youtube/ktptextui_message_filter_youtube.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109281/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>