Review Request 109307: Declarative Plugin: Overload file sending for url's

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109307/
-----------------------------------------------------------

(Updated March 6, 2013, 2:45 a.m.)


Review request for Telepathy and David Edmundson.


Changes
-------

Move the overloaded startFileTransfer to KTp::Actions, like David suggested.

I know there's the ship it, but I'm really tired...


Description
-------

Let the module understand URL's as well. Otherwise it was translated into a string and telepathy wouldn't understand the file:// thing.

Also this opens the possibility of implementing KIO properly, eventually.

Maybe this should go into KTp::Action, but I'm unsure.


Diffs (updated)
-----

  KTp/Declarative/declarative-ktp-actions.cpp 4e8eeee 
  KTp/Declarative/declarative-ktp-actions.h 034bcd2 
  KTp/actions.h d825bae 
  KTp/actions.cpp 2e2ae5e 

Diff: http://git.reviewboard.kde.org/r/109307/diff/


Testing
-------


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130306/0054d2ac/attachment.html>