Review Request 109307: Declarative Plugin: Overload file sending for url's

[David Edmundson]

> On March 6, 2013, 2:28 a.m., David Edmundson wrote:
> > text-ui is doing a ".toLocalFile()" on drag + drop.
> > 
> > I'd rather see this get moved to KTp::Actions fix it for all usages.
> > It won't do any harm for us to do a "toLocalFile" twice.
> 
> Aleix Pol Gonzalez wrote:
>     Is it OK to return 0 there for KTp::Action?

Good point. That will cause crashes as we directly connect to the returned object.

Fortunately we can do:
  return new Tp::PendingFailure("Lalala Local File", "What a noob", account);


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109307/#review28642
-----------------------------------------------------------


On March 6, 2013, 2:23 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109307/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 2:23 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Let the module understand URL's as well. Otherwise it was translated into a string and telepathy wouldn't understand the file:// thing.
> 
> Also this opens the possibility of implementing KIO properly, eventually.
> 
> Maybe this should go into KTp::Action, but I'm unsure.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/declarative-ktp-actions.h 034bcd2 
>   KTp/Declarative/declarative-ktp-actions.cpp 4e8eeee 
> 
> Diff: http://git.reviewboard.kde.org/r/109307/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130306/7b07b23a/attachment.html>