Review Request 109302: Set version in just one place in ktp_accounts_kcm

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109302/#review28636
-----------------------------------------------------------

Ship it!


See comment


src/version.h.in
<http://git.reviewboard.kde.org/r/109302/#comment21419>

    Do we need a header guard + license on this?
    
    I guess it wouldn't matter if it was included twice, but you don't know what someone else might add in future (what do we do in the text-ui?)
    
    License will matter when Debian packagers automatically run licensecheck (I'm sure they won't look at the contents before complaining)
    
    


- David Edmundson


On March 6, 2013, 12:47 a.m., Daniele E. Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109302/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 12:47 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Set version in just one place in ktp_accounts_kcm
> This makes releases a lot easier
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 845fe6e5d368e0896c4f9b187d3369eb40c015b9 
>   plugins/butterfly/CMakeLists.txt 7824e0c8aebe3e3caa98138ebc19bd78cff391d4 
>   plugins/butterfly/ktpaccountskcm_plugin_butterfly.desktop bb79e423d2e89d00338c48b59d6097ca52eed73d 
>   plugins/butterfly/ktpaccountskcm_plugin_butterfly.desktop.cmake PRE-CREATION 
>   plugins/gabble/CMakeLists.txt 93b85ead4a399046c8ef1d0b2b287620bdf0666e 
>   plugins/gabble/ktpaccountskcm_plugin_gabble.desktop 01754e813fe96c77f421c28a85cfcda9f39593d9 
>   plugins/gabble/ktpaccountskcm_plugin_gabble.desktop.cmake PRE-CREATION 
>   plugins/haze/CMakeLists.txt c3f48cd10c06597b3d535a44f0f1dcbc83094864 
>   plugins/haze/ktpaccountskcm_plugin_haze.desktop b0c765dfa50979382a37c64f2944f471b259f9de 
>   plugins/haze/ktpaccountskcm_plugin_haze.desktop.cmake PRE-CREATION 
>   plugins/idle/CMakeLists.txt d6b1c91d800b27481bfe7640551782b05533141a 
>   plugins/idle/ktpaccountskcm_plugin_idle.desktop f386913daa99243bd5e26567f3ee8a95ba0d824b 
>   plugins/idle/ktpaccountskcm_plugin_idle.desktop.cmake PRE-CREATION 
>   plugins/rakia/CMakeLists.txt 421728c7727191d261585469b65a78c730a474df 
>   plugins/rakia/ktpaccountskcm_plugin_rakia.desktop 0ad335d828a55c391830ca6da6060832d9716334 
>   plugins/rakia/ktpaccountskcm_plugin_rakia.desktop.cmake PRE-CREATION 
>   plugins/salut/CMakeLists.txt 77bc29f45418957ca86c8f25bd56d287d37a3d98 
>   plugins/salut/ktpaccountskcm_plugin_salut.desktop 675241941a07a463b55841f8a793c791cb077b98 
>   plugins/salut/ktpaccountskcm_plugin_salut.desktop.cmake PRE-CREATION 
>   plugins/sunshine/CMakeLists.txt 4dec46da4f70d2093b7f8ddf54c715b8f2b82d82 
>   plugins/sunshine/ktpaccountskcm_plugin_sunshine.desktop 1a8924ee98a30ac4145242ffed792af5feb8d9a9 
>   plugins/sunshine/ktpaccountskcm_plugin_sunshine.desktop.cmake PRE-CREATION 
>   src/CMakeLists.txt 56724690c2208c27b2a862319c68e87055f7d251 
>   src/kcm-telepathy-accounts.cpp 2a6a1afcfa82d4ba62d12f78a2d51134b1d3ce1b 
>   src/version.h.in PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109302/diff/
> 
> 
> Testing
> -------
> 
> Built and installed
> 
> 
> Thanks,
> 
> Daniele E. Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130306/f11dfc9e/attachment.html>