<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109302/">http://git.reviewboard.kde.org/r/109302/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See comment</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109302/diff/1/?file=117182#file117182line1" style="color: black; font-weight: bold; text-decoration: underline;">src/version.h.in</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">#define KTP_ACCOUNTS_KCM_VERSION "@KTP_ACCOUNTS_KCM_VERSION@"</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do we need a header guard + license on this?
I guess it wouldn't matter if it was included twice, but you don't know what someone else might add in future (what do we do in the text-ui?)
License will matter when Debian packagers automatically run licensecheck (I'm sure they won't look at the contents before complaining)
</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On March 6th, 2013, 12:47 a.m. UTC, Daniele E. Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Daniele E. Domenichelli.</div>
<p style="color: grey;"><i>Updated March 6, 2013, 12:47 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Set version in just one place in ktp_accounts_kcm
This makes releases a lot easier</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built and installed</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(845fe6e5d368e0896c4f9b187d3369eb40c015b9)</span></li>
<li>plugins/butterfly/CMakeLists.txt <span style="color: grey">(7824e0c8aebe3e3caa98138ebc19bd78cff391d4)</span></li>
<li>plugins/butterfly/ktpaccountskcm_plugin_butterfly.desktop <span style="color: grey">(bb79e423d2e89d00338c48b59d6097ca52eed73d)</span></li>
<li>plugins/butterfly/ktpaccountskcm_plugin_butterfly.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/gabble/CMakeLists.txt <span style="color: grey">(93b85ead4a399046c8ef1d0b2b287620bdf0666e)</span></li>
<li>plugins/gabble/ktpaccountskcm_plugin_gabble.desktop <span style="color: grey">(01754e813fe96c77f421c28a85cfcda9f39593d9)</span></li>
<li>plugins/gabble/ktpaccountskcm_plugin_gabble.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/haze/CMakeLists.txt <span style="color: grey">(c3f48cd10c06597b3d535a44f0f1dcbc83094864)</span></li>
<li>plugins/haze/ktpaccountskcm_plugin_haze.desktop <span style="color: grey">(b0c765dfa50979382a37c64f2944f471b259f9de)</span></li>
<li>plugins/haze/ktpaccountskcm_plugin_haze.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/idle/CMakeLists.txt <span style="color: grey">(d6b1c91d800b27481bfe7640551782b05533141a)</span></li>
<li>plugins/idle/ktpaccountskcm_plugin_idle.desktop <span style="color: grey">(f386913daa99243bd5e26567f3ee8a95ba0d824b)</span></li>
<li>plugins/idle/ktpaccountskcm_plugin_idle.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/rakia/CMakeLists.txt <span style="color: grey">(421728c7727191d261585469b65a78c730a474df)</span></li>
<li>plugins/rakia/ktpaccountskcm_plugin_rakia.desktop <span style="color: grey">(0ad335d828a55c391830ca6da6060832d9716334)</span></li>
<li>plugins/rakia/ktpaccountskcm_plugin_rakia.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/salut/CMakeLists.txt <span style="color: grey">(77bc29f45418957ca86c8f25bd56d287d37a3d98)</span></li>
<li>plugins/salut/ktpaccountskcm_plugin_salut.desktop <span style="color: grey">(675241941a07a463b55841f8a793c791cb077b98)</span></li>
<li>plugins/salut/ktpaccountskcm_plugin_salut.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/sunshine/CMakeLists.txt <span style="color: grey">(4dec46da4f70d2093b7f8ddf54c715b8f2b82d82)</span></li>
<li>plugins/sunshine/ktpaccountskcm_plugin_sunshine.desktop <span style="color: grey">(1a8924ee98a30ac4145242ffed792af5feb8d9a9)</span></li>
<li>plugins/sunshine/ktpaccountskcm_plugin_sunshine.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(56724690c2208c27b2a862319c68e87055f7d251)</span></li>
<li>src/kcm-telepathy-accounts.cpp <span style="color: grey">(2a6a1afcfa82d4ba62d12f78a2d51134b1d3ce1b)</span></li>
<li>src/version.h.in <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109302/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>