Review Request 109277: Group error messages

Martin Klapetek martin.klapetek at gmail.com
Tue Mar 5 17:53:20 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109277/#review28604
-----------------------------------------------------------



error-handler.cpp
<http://git.reviewboard.kde.org/r/109277/#comment21403>

    I just realized this won't be translated. But probably nothing we can do about it...
    
    (makes me curious if the server returns a localized version of the error string when you connect from non-english country)


- Martin Klapetek


On March 4, 2013, 12:36 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109277/
> -----------------------------------------------------------
> 
> (Updated March 4, 2013, 12:36 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Track error messages and only emit after 30 seconds to allow time to reconnect and hopefully reduce the number of error messages we emit
> 
> Group messages together
> Also show server messages to user to the user
> 
> 
> Diffs
> -----
> 
>   error-handler.h 60fe5e87c747978191adfbfebf31c60f3ccea07b 
>   error-handler.cpp c309f1c709f0811531a28cdd6172e5f3d93ebe7a 
> 
> Diff: http://git.reviewboard.kde.org/r/109277/diff/
> 
> 
> Testing
> -------
> 
> Absolutely none. I just needed to push this to RB before the feature freeze :)
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130305/dfd83ccc/attachment.html>


More information about the KDE-Telepathy mailing list