Review Request 109277: Group error messages

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109277/#review28580
-----------------------------------------------------------


Good start, couple notes below.


error-handler.cpp
<http://git.reviewboard.kde.org/r/109277/#comment21384>

    If we check for this in onConnectionStatusChanged(), this will be useless



error-handler.cpp
<http://git.reviewboard.kde.org/r/109277/#comment21388>

    I'm not sure about the new lines being added here as that will add new line for single notification too. I propose this check after the if (!error.shown()...
    
    if (!errorMessage.isEmpty() && i.peekNext() != m_errorMap.constEnd()) {
        errorMessage.last().append('\n');
    }



error-handler.cpp
<http://git.reviewboard.kde.org/r/109277/#comment21385>

    double ;



error-handler.cpp
<http://git.reviewboard.kde.org/r/109277/#comment21382>

    We should check if the disconnect reason is user requested, otherwise we'd store the error for manual disconnection as well.



error-handler.cpp
<http://git.reviewboard.kde.org/r/109277/#comment21383>

    Somewhere we need to watch for account being removed as the following might happen:
    
     * account is disconnected with error
     * the timer is started
     * account is removed
     * the timer times out
     * notification for removed account is shown


- Martin Klapetek


On March 4, 2013, 12:36 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109277/
> -----------------------------------------------------------
> 
> (Updated March 4, 2013, 12:36 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Track error messages and only emit after 30 seconds to allow time to reconnect and hopefully reduce the number of error messages we emit
> 
> Group messages together
> Also show server messages to user to the user
> 
> 
> Diffs
> -----
> 
>   error-handler.h 60fe5e87c747978191adfbfebf31c60f3ccea07b 
>   error-handler.cpp c309f1c709f0811531a28cdd6172e5f3d93ebe7a 
> 
> Diff: http://git.reviewboard.kde.org/r/109277/diff/
> 
> 
> Testing
> -------
> 
> Absolutely none. I just needed to push this to RB before the feature freeze :)
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130305/b7949301/attachment-0001.html>