Review Request 109267: Update PinnedContactModel to track ContactPtrs across connections

Commit Hook null at kde.org
Mon Mar 4 12:35:23 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109267/#review28540
-----------------------------------------------------------


This review has been submitted with commit 47dd02364c0379b7889ffc98f95594c62fb3cc89 by David Edmundson to branch master.

- Commit Hook


On March 3, 2013, 7:59 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109267/
> -----------------------------------------------------------
> 
> (Updated March 3, 2013, 7:59 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add a class that keeps the latest Tp::ContactPtr for a given contact ID even across reconnections
> 
> Make PinnedContactModel use PersistentContact
> 
> This fixes a bug in which contact pointers would be invalid after reconnections
> Hopefully also simplifies code
> 
> 
> Diffs
> -----
> 
>   KTp/CMakeLists.txt a8c86fabec796afb2821c5129e0c105c4a2eea3f 
>   KTp/Declarative/pinned-contacts-model.h 7f01961ae84483cee00a12894c21648c81428633 
>   KTp/Declarative/pinned-contacts-model.cpp e5febfa74189fb2dd14cb0cb9918ebaeed74961c 
>   KTp/persistent-contact.h PRE-CREATION 
>   KTp/persistent-contact.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109267/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130304/4dd30d61/attachment-0001.html>


More information about the KDE-Telepathy mailing list