Review Request 109267: Update PinnedContactModel to track ContactPtrs across connections

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109267/#review28511
-----------------------------------------------------------

Ship it!



KTp/Declarative/pinned-contacts-model.cpp
<http://git.reviewboard.kde.org/r/109267/#comment21290>

    maybe you can add it in the condition no?
    
    return p->contact() && p->contact()->...


I like it, the code ends up much cleaner.

There are some problems still, but we'll get to polish them during the beta process and they're not regressions (already there in master). I think it should get in.

- Aleix Pol Gonzalez


On March 3, 2013, 7:59 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109267/
> -----------------------------------------------------------
> 
> (Updated March 3, 2013, 7:59 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add a class that keeps the latest Tp::ContactPtr for a given contact ID even across reconnections
> 
> Make PinnedContactModel use PersistentContact
> 
> This fixes a bug in which contact pointers would be invalid after reconnections
> Hopefully also simplifies code
> 
> 
> Diffs
> -----
> 
>   KTp/CMakeLists.txt a8c86fabec796afb2821c5129e0c105c4a2eea3f 
>   KTp/Declarative/pinned-contacts-model.h 7f01961ae84483cee00a12894c21648c81428633 
>   KTp/Declarative/pinned-contacts-model.cpp e5febfa74189fb2dd14cb0cb9918ebaeed74961c 
>   KTp/persistent-contact.h PRE-CREATION 
>   KTp/persistent-contact.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109267/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130304/885871d8/attachment.html>