Review Request 111237: Merge delegate changes from kpeople branch into master

[Martin Klapetek]

> On June 25, 2013, 12:53 p.m., David Edmundson wrote:
> > contact-delegate-compact.cpp, line 56
> > <http://git.reviewboard.kde.org/r/111237/diff/1/?file=165731#file165731line56>
> >
> >     This is dangerous 
> >     
> >     index.parent() can be invalid.
> >     
> >     at which point you will get data().toUint() will fail and return 0.. which could map to any enum.
> >     
> >

I agree in principle. But we know that KTp::PersonRowType is not 0, so isSubcontact will be true if and only if the parent() is actually valid.


> On June 25, 2013, 12:53 p.m., David Edmundson wrote:
> > contact-delegate-compact.cpp, line 80
> > <http://git.reviewboard.kde.org/r/111237/diff/1/?file=165731#file165731line80>
> >
> >     I think this list -> select the first should be done in the translation proxy.
> >     
> >     Otherwise every delegate has to support both lists and single values.

I believe this was the idea - pass list of avatars and let the client choose the proper one. I can change it though.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111237/#review35050
-----------------------------------------------------------


On June 25, 2013, 12:34 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111237/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 12:34 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> as summary
> 
> 
> Diffs
> -----
> 
>   contact-delegate-compact.cpp 46bee7b 
> 
> Diff: http://git.reviewboard.kde.org/r/111237/diff/
> 
> 
> Testing
> -------
> 
> Delegate works with master
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130625/2503878d/attachment.html>