Review Request 111237: Merge delegate changes from kpeople branch into master

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111237/#review35050
-----------------------------------------------------------



contact-delegate-compact.cpp
<http://git.reviewboard.kde.org/r/111237/#comment25656>

    This is dangerous 
    
    index.parent() can be invalid.
    
    at which point you will get data().toUint() will fail and return 0.. which could map to any enum.
    
    



contact-delegate-compact.cpp
<http://git.reviewboard.kde.org/r/111237/#comment25655>

    magic number.. can this be replaced with something else.



contact-delegate-compact.cpp
<http://git.reviewboard.kde.org/r/111237/#comment25653>

    I think this list -> select the first should be done in the translation proxy.
    
    Otherwise every delegate has to support both lists and single values. 



contact-delegate-compact.cpp
<http://git.reviewboard.kde.org/r/111237/#comment25654>

    Why init to 0, to init it to the right thing later.


- David Edmundson


On June 25, 2013, 12:34 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111237/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 12:34 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> as summary
> 
> 
> Diffs
> -----
> 
>   contact-delegate-compact.cpp 46bee7b 
> 
> Diff: http://git.reviewboard.kde.org/r/111237/diff/
> 
> 
> Testing
> -------
> 
> Delegate works with master
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130625/89a94b07/attachment-0001.html>