Review Request 111099: Accept KTp::ContactGridDialog by double click

Dan Vrátil dvratil at redhat.com
Mon Jun 24 09:28:54 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111099/
-----------------------------------------------------------

(Updated June 24, 2013, 11:28 a.m.)


Review request for Telepathy.


Changes
-------

Second round: added contactDoubleClicked(Tp::AccountPtr, KTp::ContactPtr) signal to the widget so that dialog (and others) can listen to it. I also took the liberty of removing some code that seemed unnecessary and overcomplicated to me (ironic, given previous version of this patch).


Description
-------

This has been annoying me for ages, but I finally got around to fix it. Even though the change is a bit more invasive that one would expect for such a simple feature, I think it's worth it :-)


Diffs (updated)
-----

  KTp/Widgets/contact-grid-dialog.h d9d3712 
  KTp/Widgets/contact-grid-dialog.cpp f6eb45b 
  KTp/Widgets/contact-grid-widget.h d6b5468 
  KTp/Widgets/contact-grid-widget.cpp e4ce9bc 

Diff: http://git.reviewboard.kde.org/r/111099/diff/


Testing
-------


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130624/b5e90b2f/attachment.html>


More information about the KDE-Telepathy mailing list