Review Request 111099: Accept KTp::ContactGridDialog by double click

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111099/#review34824
-----------------------------------------------------------

Ship it!


OK, what you have looks like it will work. 

before you ship it, could you think about whether it would make more sense to just have an "itemDoubleClicked" signal in ContactGridWidget? That way anyone using the grid can use this feature even if they don't use the dialog. 
For example, your recent embedding in the contact-applet KCM.


- David Edmundson


On June 18, 2013, 3:14 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111099/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 3:14 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This has been annoying me for ages, but I finally got around to fix it. Even though the change is a bit more invasive that one would expect for such a simple feature, I think it's worth it :-)
> 
> 
> Diffs
> -----
> 
>   KTp/Widgets/contact-grid-dialog.h d9d3712 
>   KTp/Widgets/contact-grid-dialog.cpp f6eb45b 
>   KTp/Widgets/contact-grid-widget-private.h PRE-CREATION 
>   KTp/Widgets/contact-grid-widget.h d6b5468 
>   KTp/Widgets/contact-grid-widget.cpp e4ce9bc 
> 
> Diff: http://git.reviewboard.kde.org/r/111099/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130621/8675bd77/attachment-0001.html>