Review Request 111156: Keep aspect ratio on contact applet

[Aleix Pol Gonzalez]

> On June 20, 2013, 10:59 p.m., David Edmundson wrote:
> > contact/src/declarative/contents/ui/Avatar.qml, line 104
> > <http://git.reviewboard.kde.org/r/111156/diff/1/?file=164963#file164963line104>
> >
> >     (Note that I am aware this is a completely backwards way of doing things in QML, but refactoring is not a small task or needed to fix this bug)

Yes, you can do that in a later commit ;)


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111156/#review34800
-----------------------------------------------------------


On June 20, 2013, 10:53 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111156/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 10:53 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Keep aspect ratio on contact applet
> 
> BUG: 282273
> 
> 
> Diffs
> -----
> 
>   contact/src/declarative/contents/ui/Avatar.qml 6133563ade5196cff5399857d819d1466e0b411f 
> 
> Diff: http://git.reviewboard.kde.org/r/111156/diff/
> 
> 
> Testing
> -------
> 
> Opened a contact with a previously squished avatar.
> 
> Checked starting chats still worked.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130620/f85f739b/attachment.html>