Review Request 111156: Keep aspect ratio on contact applet
David Edmundson
david at davidedmundson.co.uk
Thu Jun 20 22:59:11 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111156/#review34800
-----------------------------------------------------------
contact/src/declarative/contents/ui/Avatar.qml
<http://git.reviewboard.kde.org/r/111156/#comment25509>
I fixed this :)
contact/src/declarative/contents/ui/Avatar.qml
<http://git.reviewboard.kde.org/r/111156/#comment25510>
(Note that I am aware this is a completely backwards way of doing things in QML, but refactoring is not a small task or needed to fix this bug)
- David Edmundson
On June 20, 2013, 10:53 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111156/
> -----------------------------------------------------------
>
> (Updated June 20, 2013, 10:53 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Keep aspect ratio on contact applet
>
> BUG: 282273
>
>
> Diffs
> -----
>
> contact/src/declarative/contents/ui/Avatar.qml 6133563ade5196cff5399857d819d1466e0b411f
>
> Diff: http://git.reviewboard.kde.org/r/111156/diff/
>
>
> Testing
> -------
>
> Opened a contact with a previously squished avatar.
>
> Checked starting chats still worked.
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130620/ac45f787/attachment.html>
More information about the KDE-Telepathy
mailing list