Review Request 110870: Add Optional Accounts-SSO support to ktp-auth-handler

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110870/#review33912
-----------------------------------------------------------

Ship it!


Everything looks good to me, lets just check everyone is happy the find_package before pushing.


sasl-auth-op.cpp
<http://git.reviewboard.kde.org/r/110870/#comment24977>

    FUTURE OPTIMISATION: There's no point us opening the wallet if we're going to use web accounts...which will then open the wallet itself.
    
    



x-telepathy-sso-operation.cpp
<http://git.reviewboard.kde.org/r/110870/#comment24975>

    That's not my correct email address. (I blame KDevelop :P ) 
    
    Will fix in the SSO branch, don't push till I run home and fix it.
    
    (or if you're in a hurry you can change it. kde at davidedmundson.co.uk please .. sorry about that)


- David Edmundson


On June 7, 2013, 5:19 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110870/
> -----------------------------------------------------------
> 
> (Updated June 7, 2013, 5:19 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Adds Accounts-SSO support to ktp-auth-handler by checking if the account has a StorageIdentifier (which we assume comes from Accounts) and X-FACEBOOK-PLATFORM mechanism exsts.
> 
> We'll probably have to implement something special for Google as well.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6c51903 
>   cmake/modules/FindAccountsQt.cmake PRE-CREATION 
>   cmake/modules/FindSignOnQt.cmake PRE-CREATION 
>   getcredentialsjob.h PRE-CREATION 
>   getcredentialsjob.cpp PRE-CREATION 
>   sasl-auth-op.h 6e0e5ef 
>   sasl-auth-op.cpp b745234 
>   x-telepathy-sso-operation.h PRE-CREATION 
>   x-telepathy-sso-operation.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110870/diff/
> 
> 
> Testing
> -------
> 
> Tested with and without support, it builds and works in both cases.
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130607/3646c76f/attachment.html>