Review Request 110870: Add Optional Accounts-SSO support to ktp-auth-handler

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110870/
-----------------------------------------------------------

(Updated June 7, 2013, 5:19 p.m.)


Review request for Telepathy.


Changes
-------

Fixed all issues pointed out by David.


Description
-------

Adds Accounts-SSO support to ktp-auth-handler by checking if the account has a StorageIdentifier (which we assume comes from Accounts) and X-FACEBOOK-PLATFORM mechanism exsts.

We'll probably have to implement something special for Google as well.


Diffs (updated)
-----

  CMakeLists.txt 6c51903 
  cmake/modules/FindAccountsQt.cmake PRE-CREATION 
  cmake/modules/FindSignOnQt.cmake PRE-CREATION 
  getcredentialsjob.h PRE-CREATION 
  getcredentialsjob.cpp PRE-CREATION 
  sasl-auth-op.h 6e0e5ef 
  sasl-auth-op.cpp b745234 
  x-telepathy-sso-operation.h PRE-CREATION 
  x-telepathy-sso-operation.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/110870/diff/


Testing
-------

Tested with and without support, it builds and works in both cases.


Thanks,

Àlex Fiestas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130607/9e10b141/attachment.html>