Review Request 110870: Add Optional Accounts-SSO support to ktp-auth-handler

[Daniele E. Domenichelli]

> On June 7, 2013, 4:24 p.m., David Edmundson wrote:
> > CMakeLists.txt, line 77
> > <http://git.reviewboard.kde.org/r/110870/diff/1/?file=149002#file149002line77>
> >
> >     File format is different.
> >     
> >     Is this:
> >     1) a mistake
> >     2) because we're going to get it from libkwebaccounts in the future?

And it's using KJobs, while all the other classes here are using PendingOperations... but perhaps not a real issue, especially if it will end in libkwebaccounts


- Daniele E.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110870/#review33905
-----------------------------------------------------------


On June 7, 2013, 4:03 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110870/
> -----------------------------------------------------------
> 
> (Updated June 7, 2013, 4:03 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Adds Accounts-SSO support to ktp-auth-handler by checking if the account has a StorageIdentifier (which we assume comes from Accounts) and X-FACEBOOK-PLATFORM mechanism exsts.
> 
> We'll probably have to implement something special for Google as well.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6c51903 
>   cmake/modules/FindAccountsQt.cmake PRE-CREATION 
>   cmake/modules/FindSignOnQt.cmake PRE-CREATION 
>   getcredentialsjob.h PRE-CREATION 
>   getcredentialsjob.cpp PRE-CREATION 
>   sasl-auth-op.h 6e0e5ef 
>   sasl-auth-op.cpp b745234 
>   x-telepathy-sso-operation.h PRE-CREATION 
>   x-telepathy-sso-operation.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110870/diff/
> 
> 
> Testing
> -------
> 
> Tested with and without support, it builds and works in both cases.
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130607/ba4e6ece/attachment.html>