Review Request 110870: Add Optional Accounts-SSO support to ktp-auth-handler

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110870/#review33905
-----------------------------------------------------------


Very neat and tidy, good work.

One super important comment. The rest less so.


CMakeLists.txt
<http://git.reviewboard.kde.org/r/110870/#comment24962>

    File format is different.
    
    Is this:
    1) a mistake
    2) because we're going to get it from libkwebaccounts in the future?



getcredentialsjob.h
<http://git.reviewboard.kde.org/r/110870/#comment24967>

    AFAIK we're LGPL



sasl-auth-op.h
<http://git.reviewboard.kde.org/r/110870/#comment24963>

    wordaround -> workaround
    
    (but well done for putting this link A+++++++ )



sasl-auth-op.cpp
<http://git.reviewboard.kde.org/r/110870/#comment24964>

    At some point, this needs doing.
    It's now repeated 3 times.
    
    Doesn't need doing now, I can do it afterwards



sasl-auth-op.cpp
<http://git.reviewboard.kde.org/r/110870/#comment24965>

    This doesn't look right.
    
    We don't want to enter getProperties() before onGetAccountStorageFetched is called. Otherwise m_accountStorageId may be blank.
    
    by calling setReady() we have a race condition between the SASL interface being ready and the accountstorageinterface.
    
    Solutions:
    
    1) move setReady() into onGetAccountStorageFetched
    
    2) change setReady to create a Tp::PendingComposite  job of both things.
    
    Only start SASL processing when both are complete... 
    
    Number 2 probably isn't really worth it we're going to avoid these annoying async dbus calls with my TpQt patch.
    


- David Edmundson


On June 7, 2013, 4:03 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110870/
> -----------------------------------------------------------
> 
> (Updated June 7, 2013, 4:03 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Adds Accounts-SSO support to ktp-auth-handler by checking if the account has a StorageIdentifier (which we assume comes from Accounts) and X-FACEBOOK-PLATFORM mechanism exsts.
> 
> We'll probably have to implement something special for Google as well.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6c51903 
>   cmake/modules/FindAccountsQt.cmake PRE-CREATION 
>   cmake/modules/FindSignOnQt.cmake PRE-CREATION 
>   getcredentialsjob.h PRE-CREATION 
>   getcredentialsjob.cpp PRE-CREATION 
>   sasl-auth-op.h 6e0e5ef 
>   sasl-auth-op.cpp b745234 
>   x-telepathy-sso-operation.h PRE-CREATION 
>   x-telepathy-sso-operation.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110870/diff/
> 
> 
> Testing
> -------
> 
> Tested with and without support, it builds and works in both cases.
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130607/d1d9472b/attachment-0001.html>