Review Request 110739: Create and cache the contact groups

Commit Hook null at kde.org
Mon Jun 3 11:16:21 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110739/
-----------------------------------------------------------

(Updated June 3, 2013, 11:16 a.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy, Aleix Pol Gonzalez, David Edmundson, and Martin Klapetek.


Description
-------

    Create and cache the contact groups
    
    Earlier, if a group contained more than one contact then it the contact
    group was created that many times cause a new SimpleResource was created
    each time.
    
    With this method we cache the contact groups so that they are only
    created once, and once they have been created we do not unnecessarily
    send a new SimpleResource to get merged into the existing contact group.


Diffs
-----

  nepomuk-storage.h ad5b6bc 
  nepomuk-storage.cpp adee609 

Diff: http://git.reviewboard.kde.org/r/110739/diff/


Testing
-------

No more duplicate contact groups.


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130603/09e2989b/attachment.html>


More information about the KDE-Telepathy mailing list