Review Request 111727: accounts-kcm gui code for steam plugin of libpurple

[Thomas Pfeiffer]

> On July 29, 2013, 10:56 a.m., Thomas Pfeiffer wrote:
> > File Attachment: KCM (added by Dave on Daniel's behalf)
> > <http://git.reviewboard.kde.org/r/111727/#fcomment62>
> >
> >     The explanation should be below the Steam Guard field and left-aligned to the input widget
> 
> David Edmundson wrote:
>     Is that part of the HIG written now then?

Not yet, but since Heiko and me agree on it, it most likely will be written that way


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111727/#review36731
-----------------------------------------------------------


On July 28, 2013, 1:52 p.m., Daniel Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111727/
> -----------------------------------------------------------
> 
> (Updated July 28, 2013, 1:52 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Gui code for accounts-kcm that gives the steam-mobile plugin of libpurple a native/shiny look. I Didn't include the https tickbox because it seems to not function.
> 
> 
> Diffs
> -----
> 
>   plugins/haze/CMakeLists.txt ebc28c6 
>   plugins/haze/haze-account-ui-plugin.cpp e618518 
>   plugins/haze/haze-steam-account.h PRE-CREATION 
>   plugins/haze/haze-steam-account.cpp PRE-CREATION 
>   plugins/haze/steam-main-options-widget.h PRE-CREATION 
>   plugins/haze/steam-main-options-widget.cpp PRE-CREATION 
>   plugins/haze/steam-main-options-widget.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111727/diff/
> 
> 
> Testing
> -------
> 
> Created new account and logged in successfully.
> 
> 
> File Attachments
> ----------------
> 
> KCM (added by Dave on Daniel's behalf)
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/07/28/steam1.png
> 
> 
> Thanks,
> 
> Daniel Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130729/e2f31b79/attachment-0001.html>