Review Request 111682: Make TelepathyLoggerQt an optional dependency of ktp-common-internals

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111682/#review36491
-----------------------------------------------------------

Ship it!


Ship it to all of them. 

Though I don't want all these staying long term. Temporary solutions do have a habbit of doing that.
I'm making a list of all the requirements for TpLogger, so we know what we're doing for the abstract logger part. Also I might try moving it all into k-c-i within the 0.7 timeframe.


CMakeLists.txt
<http://git.reviewboard.kde.org/r/111682/#comment26928>

    We should expand on why we use it, not just what it is.
    
    I'd like the message to say something more like:
    "Qt Bindings for TelpathyLogger. This is used for showing chat history with a contact. It is HIGHLY recommended. 
    
    If you are a distribution packager and you see this message go back and do it again properly".


- David Edmundson


On July 25, 2013, 2:43 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111682/
> -----------------------------------------------------------
> 
> (Updated July 25, 2013, 2:43 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Given it's a temporary solution before we come up with some abstraction for 0.8, I think #ifdefs are fine
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt db298f2 
>   KTp/CMakeLists.txt 203ed99 
>   KTp/message-processor.h 42f8be6 
>   KTp/message-processor.cpp ea2699d 
>   KTp/message.h 982b8cf 
>   KTp/message.cpp fa9c608 
>   KTp/outgoing-message.cpp 055017e 
> 
> Diff: http://git.reviewboard.kde.org/r/111682/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130725/f7bea768/attachment.html>