<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111682/">http://git.reviewboard.kde.org/r/111682/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship it to all of them.
Though I don't want all these staying long term. Temporary solutions do have a habbit of doing that.
I'm making a list of all the requirements for TpLogger, so we know what we're doing for the abstract logger part. Also I might try moving it all into k-c-i within the 0.7 timeframe.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111682/diff/1/?file=173266#file173266line28" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">28</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">macro_log_feature</span><span class="p">(</span><span class="s">TELEPATHY_LOGGER_QT4_FOUND</span> <span class="s2">"TelepatyLoggerQt4"</span> <span class="s2">"Qt bindings for TelepathyLogger"</span> <span class="s2">"http://projects.kde.org/telepathy-logger-qt"</span> <span class="s">FALSE</span> <span class="s2">""</span> <span class="s2">""</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We should expand on why we use it, not just what it is.
I'd like the message to say something more like:
"Qt Bindings for TelpathyLogger. This is used for showing chat history with a contact. It is HIGHLY recommended.
If you are a distribution packager and you see this message go back and do it again properly".</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On July 25th, 2013, 2:43 p.m. UTC, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated July 25, 2013, 2:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Given it's a temporary solution before we come up with some abstraction for 0.8, I think #ifdefs are fine</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(db298f2)</span></li>
<li>KTp/CMakeLists.txt <span style="color: grey">(203ed99)</span></li>
<li>KTp/message-processor.h <span style="color: grey">(42f8be6)</span></li>
<li>KTp/message-processor.cpp <span style="color: grey">(ea2699d)</span></li>
<li>KTp/message.h <span style="color: grey">(982b8cf)</span></li>
<li>KTp/message.cpp <span style="color: grey">(fa9c608)</span></li>
<li>KTp/outgoing-message.cpp <span style="color: grey">(055017e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111682/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>