Review Request 111522: Rework Youtube filter

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111522/#review35979
-----------------------------------------------------------



filters/youtube/youtube-filter.cpp
<http://git.reviewboard.kde.org/r/111522/#comment26636>

    We used to support youtu.be links. This is a regression



filters/youtube/youtube-filter.cpp
<http://git.reviewboard.kde.org/r/111522/#comment26686>

    I can't allow synchronous calls in the text-ui. Sorry. If you open the log viewer you'll block for ages. 
    
    We do the iframe mostly to avoid the sync behaviour. Original code actually looked something like this, it was changed for a reason.
    
    See the bugzilla plugin and copy that. That also has an async JSON query. It's not perfect, but it's way better than blocking. In many ways, I think the principle behind doing web calls in JS is nicer than the proposed design we did in Cambridge. 


- David Edmundson


On July 15, 2013, 3:03 p.m., Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111522/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 3:03 p.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Daniele E. Domenichelli.
> 
> 
> Description
> -------
> 
> This patch reworks the filter plugin for youtube. Instead of using a quite weak heuristics, use oembed straight from youtube, which gives us also a couple more neat features (such as replacing the URL with the video title).
> 
> Anyway - as a suggestion, I'd give up embedding the video and use the thumbnail instead (which we now have access to).
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 1d16dc7 
>   filters/youtube/CMakeLists.txt 1bceadb 
>   filters/youtube/youtube-filter.h dbea04a 
>   filters/youtube/youtube-filter.cpp 81681ac 
> 
> Diff: http://git.reviewboard.kde.org/r/111522/diff/
> 
> 
> Testing
> -------
> 
> Tested with drdanz, works
> 
> 
> Thanks,
> 
> Dario Freddi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130716/2ae995ed/attachment.html>