Review Request 111522: Rework Youtube filter

Dario Freddi drf at kde.org
Mon Jul 15 15:03:40 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111522/
-----------------------------------------------------------

Review request for Telepathy, David Edmundson and Daniele E. Domenichelli.


Description
-------

This patch reworks the filter plugin for youtube. Instead of using a quite weak heuristics, use oembed straight from youtube, which gives us also a couple more neat features (such as replacing the URL with the video title).

Anyway - as a suggestion, I'd give up embedding the video and use the thumbnail instead (which we now have access to).


Diffs
-----

  CMakeLists.txt 1d16dc7 
  filters/youtube/CMakeLists.txt 1bceadb 
  filters/youtube/youtube-filter.h dbea04a 
  filters/youtube/youtube-filter.cpp 81681ac 

Diff: http://git.reviewboard.kde.org/r/111522/diff/


Testing
-------

Tested with drdanz, works


Thanks,

Dario Freddi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130715/009612c3/attachment-0001.html>


More information about the KDE-Telepathy mailing list