Review Request 111440: Upgrade the Tp::Connection to upgrade FeatureRoster inside GlobalContactManager

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111440/
-----------------------------------------------------------

(Updated July 9, 2013, 11:48 a.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Description
-------

Upgrade the Tp::Connection to include FeatureRoster inside GlobalContactManager

GlobalContactManager is useless without FeatureRoster so it makes sense
that if one instantiates this class, we upgrade the connection.

This will allow apps that only occasionally need a full contact list
such as contact-applet and text-ui to not rely on FeatureRoster in the factory and thus
can a connection object without loading details on every contact ever.

This is an important step towards a singleton AccountManager (I now have a plan), in addition
text-ui will load substantially faster.


Diffs
-----

  KTp/global-contact-manager.h 1c903c12775c096d93fef1ec0e313ff2b2824262 
  KTp/global-contact-manager.cpp c293e005f1ab0436dcd5c77ddc6607dba1f18896 
  KTp/types.h 652a7eadce080ff60cbfd1334c00476fe4bb4cd3 

Diff: http://git.reviewboard.kde.org/r/111440/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130709/8b288728/attachment.html>