Review Request 108639: Upgrade contact in KTp::ContactInfoDialog when needed
David Edmundson
david at davidedmundson.co.uk
Tue Jan 29 15:01:17 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108639/#review26368
-----------------------------------------------------------
Ship it!
- David Edmundson
On Jan. 28, 2013, 10:20 a.m., Dan Vrátil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108639/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2013, 10:20 a.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> If contact does not support FeatureAvatarData or FeatureInfo, use upgradeContacts() to enable the feature.
>
> This allows removing Tp::Contact::FeatureInfo from factory in ktp-contact-list while still being able to display all info in KTp::ContactInfoDialog.
>
>
> Diffs
> -----
>
> KTp/contact-info-dialog.h dd320ad
> KTp/contact-info-dialog.cpp b625065
>
> Diff: http://git.reviewboard.kde.org/r/108639/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Vrátil
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130129/db01ee21/attachment.html>
More information about the KDE-Telepathy
mailing list