Review Request 108639: Upgrade contact in KTp::ContactInfoDialog when needed

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108639/#review26366
-----------------------------------------------------------



KTp/contact-info-dialog.cpp
<http://git.reviewboard.kde.org/r/108639/#comment20093>

    You may as well just always upgrade. TpQt is pretty clever, if it doesn't need to add anything it will just emit the finished() signal straight away.
    
    Then you can simplify the code a bit.


- David Edmundson


On Jan. 28, 2013, 10:20 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108639/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2013, 10:20 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> If contact does not support FeatureAvatarData or FeatureInfo, use upgradeContacts() to enable the feature.
> 
> This allows removing Tp::Contact::FeatureInfo from factory in ktp-contact-list while still being able to display all info in KTp::ContactInfoDialog.
> 
> 
> Diffs
> -----
> 
>   KTp/contact-info-dialog.h dd320ad 
>   KTp/contact-info-dialog.cpp b625065 
> 
> Diff: http://git.reviewboard.kde.org/r/108639/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130129/1d77a2c8/attachment.html>