Review Request 108649: Use a QSharedDataPointer in message class

Dan Vrátil dvratil at redhat.com
Tue Jan 29 14:58:38 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108649/#review26367
-----------------------------------------------------------

Ship it!


Ship It!

- Dan Vrátil


On Jan. 28, 2013, 6:31 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108649/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2013, 6:31 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Use a QSharedDataPointer in message class (implicitly shared)
> 
> Simpler faster code when copying which happens a lot.
> 
> 
> Diffs
> -----
> 
>   KTp/message.h 581a2e20d025a972e8b58ae5e2635a381d000011 
>   KTp/message.cpp d814a996d7e07d0cea70ddcff11ad7e00b904614 
> 
> Diff: http://git.reviewboard.kde.org/r/108649/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130129/f3de6493/attachment.html>


More information about the KDE-Telepathy mailing list