Review Request 108571: Allow a separate config for group chats

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108571/#review26125
-----------------------------------------------------------


There are lots of whitespaces, please remove them.

I'm concerned about the change in how the settings is saved. It's not backwards compatible because the group name was changed from Appearance to ChatAppearance, so after update you will be presented with the default theme (and you will have an unused entries in ktelepathyrc)

I suggest "Appearance" group is used to store single chat theme (so the same way it's done now), and group chat theme is saved in "Appearance/GroupChat" subgroup.


config/appearance-config.cpp
<http://git.reviewboard.kde.org/r/108571/#comment19878>

    Should be m_groupTab->loadTab() I guess


- Dan Vrátil


On Jan. 24, 2013, 1:07 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108571/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2013, 1:07 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Allow a separate config for group chats
> 
> Work by our code-in student Huba Nagy. I've not reviewed it myself.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.cpp cb7a23432c7114a4d63a66040cbedb7916a99716 
>   config/CMakeLists.txt 24e9e80ffd9c23515a457a5d2f0ba8271e207e17 
>   config/appearance-config-tab.h PRE-CREATION 
>   config/appearance-config-tab.cpp PRE-CREATION 
>   config/appearance-config.h 5b6c83d6ac4001f1d28b3ce1cb8e18a38e5269c5 
>   config/appearance-config.cpp a88dd028a2ec46f0b945ee3297659ce4410895ee 
>   config/kcm_ktp_chat_appearance.desktop e693a62647af802eb6cdfaf68d3f8413c03b8bb0 
>   lib/adium-theme-view.cpp 81beaa50c0ae7cc957b71cadfca5f6360a5198df 
> 
> Diff: http://git.reviewboard.kde.org/r/108571/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130124/4804119e/attachment.html>