<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108571/">http://git.reviewboard.kde.org/r/108571/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There are lots of whitespaces, please remove them.
I'm concerned about the change in how the settings is saved. It's not backwards compatible because the group name was changed from Appearance to ChatAppearance, so after update you will be presented with the default theme (and you will have an unused entries in ktelepathyrc)
I suggest "Appearance" group is used to store single chat theme (so the same way it's done now), and group chat theme is saved in "Appearance/GroupChat" subgroup.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108571/diff/1/?file=109080#file109080line287" style="color: black; font-weight: bold; text-decoration: underline;">config/appearance-config.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">285</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">manager</span><span class="o">-></span><span class="n">loadStyles</span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">72</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_singleTab</span><span class="o">-></span><span class="n">loadTab</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should be m_groupTab->loadTab() I guess</pre>
</div>
<br />
<p>- Dan</p>
<br />
<p>On January 24th, 2013, 1:07 p.m. CET, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2013, 1:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Allow a separate config for group chats
Work by our code-in student Huba Nagy. I've not reviewed it myself.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/chat-window.cpp <span style="color: grey">(cb7a23432c7114a4d63a66040cbedb7916a99716)</span></li>
<li>config/CMakeLists.txt <span style="color: grey">(24e9e80ffd9c23515a457a5d2f0ba8271e207e17)</span></li>
<li>config/appearance-config-tab.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/appearance-config-tab.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/appearance-config.h <span style="color: grey">(5b6c83d6ac4001f1d28b3ce1cb8e18a38e5269c5)</span></li>
<li>config/appearance-config.cpp <span style="color: grey">(a88dd028a2ec46f0b945ee3297659ce4410895ee)</span></li>
<li>config/kcm_ktp_chat_appearance.desktop <span style="color: grey">(e693a62647af802eb6cdfaf68d3f8413c03b8bb0)</span></li>
<li>lib/adium-theme-view.cpp <span style="color: grey">(81beaa50c0ae7cc957b71cadfca5f6360a5198df)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108571/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>