Review Request 108558: Add a method to AccountsComboBox to pre-select an account
Dan Vrátil
dvratil at redhat.com
Wed Jan 23 07:18:55 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108558/#review26054
-----------------------------------------------------------
Ship it!
Just fix the coding style before pushing.
KTp/Widgets/accounts-combo-box.cpp
<http://git.reviewboard.kde.org/r/108558/#comment19849>
Put spaces around "=" and "<" and after ";"
- Dan Vrátil
On Jan. 23, 2013, 12:35 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108558/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2013, 12:35 a.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Add a method to AccountsComboBox to pre-select an account.
>
> This came up from porting the call UI. Not having this will result in a regression (one could do it by looping through the QComboBox, but I'd rather internalise everything). Will probably be useful for Join Chat Room dialog too.
>
>
> Diffs
> -----
>
> KTp/Widgets/accounts-combo-box.h b5a17dacabd2428d46788028507995de129eb556
> KTp/Widgets/accounts-combo-box.cpp d1ffbacd44e3e5d525ad4bd0c153defbfa9709f1
>
> Diff: http://git.reviewboard.kde.org/r/108558/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130123/60c30609/attachment.html>
More information about the KDE-Telepathy
mailing list