Review Request 108558: Add a method to AccountsComboBox to pre-select an account

David Edmundson david at davidedmundson.co.uk
Tue Jan 22 23:35:04 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108558/
-----------------------------------------------------------

(Updated Jan. 22, 2013, 11:35 p.m.)


Review request for Telepathy.


Changes
-------

Updated as per Dan's comments.
Also added an extra convenience method.


Description
-------

Add a method to AccountsComboBox to pre-select an account.

This came up from porting the call UI. Not having this will result in a regression (one could do it by looping through the QComboBox, but I'd rather internalise everything). Will probably be useful for Join Chat Room dialog too.


Diffs (updated)
-----

  KTp/Widgets/accounts-combo-box.h b5a17dacabd2428d46788028507995de129eb556 
  KTp/Widgets/accounts-combo-box.cpp d1ffbacd44e3e5d525ad4bd0c153defbfa9709f1 

Diff: http://git.reviewboard.kde.org/r/108558/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130122/1830fec9/attachment.html>


More information about the KDE-Telepathy mailing list