Ship it? Who should be doing code reviews

[Aleix Pol]

On Sun, Jan 20, 2013 at 1:24 PM, David Edmundson <david at davidedmundson.co.uk
> wrote:

> This is in response to a comment I saw on reviewboard last night, but
> I want to reply to the whole mailing list.
>
> If you've ever committed code on KTp, you should be helping do reviews
> and you should click "ship it!" if you understand the code and agree
> with the patch. I don't want people to think "I'm not the manager, I
> shouldn't be clicking Ship it". In KTp, all developers are equal, and
> should all have equal powers & responsibility.
>
> If I write a patch, and I want a specific person to review it, I'll
> simply wait for a second "ship it" from someone else. If you review
> someone elses code and click ship it! and I disagree, I'll simply
> comment afterwards. Even if the code gets commmitted, I'll still see
> the review and can fix it afterwards.
>
> David.
> _______________________________________________
> KDE-Telepathy mailing list
> KDE-Telepathy at kde.org
> https://mail.kde.org/mailman/listinfo/kde-telepathy
>

I get the message. :P

Thanks!
Aleix
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130121/51749dd3/attachment.html>