Review Request 108153: Fix height for local-xmpp list view

[Stefan Eggers]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108153/
-----------------------------------------------------------

(Updated Jan. 20, 2013, 12:02 p.m.)


Review request for Telepathy.


Changes
-------

Set the maximum size of the list view in addition to the minimum size. This has the effect that the list view has minimum and maximum size both equal the size of its content plus a few pixels for its border and is thus always exactly the expected size.

For really large fonts (48 in my tests) the list view was previously too small and I got truncated text. With this change it is now properly sized, too.


Description (updated)
-------

Fix height for local-xmpp list view

The list item was slightly smaller than the containing list view for
small font sizes. When it was selected there was a small strip below
which didn't belong to the item and didn't change color. Fixed this.

For really large fonts the list view didn't get high enough and thus
got truncated. This gets fixed at the same time.


This addresses bug 309050.
    http://bugs.kde.org/show_bug.cgi?id=309050


Diffs (updated)
-----

  src/kcm-telepathy-accounts.cpp 9ca5949bc9ec90d1e2356fbe89afb8c298eeb14c 

Diff: http://git.reviewboard.kde.org/r/108153/diff/


Testing (updated)
-------

I set the font size to 5 for all fonts to see if the bug is fixed. Without this change I get a white strip (see the linked picture in the bug report). With the change there is no white strip anymore.

I also tested a case of a really large font with font size 48. Without this change the second line of text was truncated, with the change it was looking right.


Thanks,

Stefan Eggers

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130120/8d931d63/attachment.html>