Review Request 108435: Update declarative to use new models

[David Edmundson]

> On Jan. 16, 2013, 2:34 p.m., Aleix Pol Gonzalez wrote:
> > KTp/Declarative/contact-list.h, line 34
> > <http://git.reviewboard.kde.org/r/108435/diff/1/?file=107427#file107427line34>
> >
> >     I wouldn't leave both. The ktp declarative module was made public last week afterall, so there is nothing to be compatible with.
> >     
> >     I'd better fix the plasmoid ;)

OK. I think you only use one anyway, I can just remove the right one.


On Jan. 16, 2013, 2:34 p.m., David Edmundson wrote:
> > Do the new models use the same roles and naming as the former implementation?

Right now, yes. To make porting easier. 

Near future, maybe not. See the mailing list thread you just replied to :)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108435/#review25649
-----------------------------------------------------------


On Jan. 16, 2013, 1:37 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108435/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2013, 1:37 a.m.)
> 
> 
> Review request for Telepathy and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
> Update declarative to use new models
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/contact-list.h a405b86561d6288fcd7ff711197415be35df768b 
>   KTp/Declarative/contact-list.cpp 52ee06ba4ef128375d49c325828f7352dd5a8eef 
>   KTp/Models/abstract-grouping-proxy-model.cpp ea9044df197f748a1654f75f33ba42126263c10a 
>   KTp/Models/contacts-list-model.cpp 604bca9af309d9e19532a840f56dddf564f32859 
> 
> Diff: http://git.reviewboard.kde.org/r/108435/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130116/b8798eb9/attachment.html>