Review Request 108435: Update declarative to use new models

Aleix Pol Gonzalez aleixpol at gmail.com
Wed Jan 16 14:34:21 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108435/#review25649
-----------------------------------------------------------



KTp/Declarative/contact-list.h
<http://git.reviewboard.kde.org/r/108435/#comment19547>

    I wouldn't leave both. The ktp declarative module was made public last week afterall, so there is nothing to be compatible with.
    
    I'd better fix the plasmoid ;)


Do the new models use the same roles and naming as the former implementation?

- Aleix Pol Gonzalez


On Jan. 16, 2013, 1:37 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108435/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2013, 1:37 a.m.)
> 
> 
> Review request for Telepathy and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
> Update declarative to use new models
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/contact-list.h a405b86561d6288fcd7ff711197415be35df768b 
>   KTp/Declarative/contact-list.cpp 52ee06ba4ef128375d49c325828f7352dd5a8eef 
>   KTp/Models/abstract-grouping-proxy-model.cpp ea9044df197f748a1654f75f33ba42126263c10a 
>   KTp/Models/contacts-list-model.cpp 604bca9af309d9e19532a840f56dddf564f32859 
> 
> Diff: http://git.reviewboard.kde.org/r/108435/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130116/ceb9d0c9/attachment.html>


More information about the KDE-Telepathy mailing list