Review Request 108432: Copy or move contact by dragging between groups

[Dan Vrátil]

> On Jan. 16, 2013, 1:18 a.m., David Edmundson wrote:
> > contact-list-widget.cpp, line 675
> > <http://git.reviewboard.kde.org/r/108432/diff/1/?file=107423#file107423line675>
> >
> >     you shouldn't need to add the sequence to the string yourself.
> >     
> >     I think if you add the shortcut to the action it should appear.

This is how libkonq does it. There is no default shortcut for these actions and adding QKeySequence(Qt::ShiftModifier) directly results in "Shift+" (therefore the chop(1) above).


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108432/#review25617
-----------------------------------------------------------


On Jan. 16, 2013, 1:08 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108432/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2013, 1:08 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> As discussed on ML, this patch adds a popup menu that appears when user drops a contact into a group. 
> 
> When user holds Shift on drag start, no popup menu appears and contact is moved. 
> When user holds Ctrl on drag start, no popup menu appears and contact is copied.
> Otherwise the popup menu always appears.
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.cpp d60f1bb 
>   contact-list-widget_p.h 68e0302 
> 
> Diff: http://git.reviewboard.kde.org/r/108432/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130116/c03460bc/attachment.html>