Review Request 108432: Copy or move contact by dragging between groups

David Edmundson david at davidedmundson.co.uk
Wed Jan 16 00:18:48 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108432/#review25617
-----------------------------------------------------------



contact-list-widget.cpp
<http://git.reviewboard.kde.org/r/108432/#comment19536>

    Qt::IgnoreAction 



contact-list-widget.cpp
<http://git.reviewboard.kde.org/r/108432/#comment19537>

    you shouldn't need to add the sequence to the string yourself.
    
    I think if you add the shortcut to the action it should appear.


- David Edmundson


On Jan. 16, 2013, 12:08 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108432/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2013, 12:08 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> As discussed on ML, this patch adds a popup menu that appears when user drops a contact into a group. 
> 
> When user holds Shift on drag start, no popup menu appears and contact is moved. 
> When user holds Ctrl on drag start, no popup menu appears and contact is copied.
> Otherwise the popup menu always appears.
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.cpp d60f1bb 
>   contact-list-widget_p.h 68e0302 
> 
> Diff: http://git.reviewboard.kde.org/r/108432/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130116/e72723e5/attachment.html>


More information about the KDE-Telepathy mailing list