Review Request 108402: Make it possible to start conversations from the Quick Chat plasmoid: Plasmoid-Side

[Aleix Pol Gonzalez]

> On Jan. 14, 2013, 9:30 a.m., David Edmundson wrote:
> > chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml, line 21
> > <http://git.reviewboard.kde.org/r/108402/diff/1/?file=107128#file107128line21>
> >
> >     Why has this changed?
> >     
> >     AFAIK 1.1 is standardly used.

Yes, one of the problems that happen when code is not only refactored but random things change (AKA this or indentation).

I changed it to 1.1


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108402/#review25432
-----------------------------------------------------------


On Jan. 14, 2013, 4:02 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108402/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2013, 4:02 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> I've wanted to use this plasmoid for longtime, I fear that the reason why I'm not using it yet is because I can't start chats from there. The plan is that this will improve the situation, to some extent.
> 
> The important part about the patch is that the root element is refactored into a grid that can have different elements. Now I added a button with a contactlist that probably should go, but eventually i'd like to have non-conversation buttons so that one can pin contacts.
> 
> ** This is the plasmoid part after the split. You can follow the discussion in https://git.reviewboard.kde.org/r/107811/ **
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/config/main.xml PRE-CREATION 
>   chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml 818d93f 
>   chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml 8a8d851 
>   chat/org.kde.ktp-chat/contents/ui/ConversationDelegateButton.qml PRE-CREATION 
>   chat/org.kde.ktp-chat/contents/ui/main.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/108402/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130115/76830e2a/attachment.html>