<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108402/">http://git.reviewboard.kde.org/r/108402/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 14th, 2013, 9:30 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108402/diff/1/?file=107128#file107128line21" style="color: black; font-weight: bold; text-decoration: underline;">chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kr">import</span> <span class="nx">QtQuick</span> <span class="mf">1.<span class="hl">1</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kr">import</span> <span class="nx">QtQuick</span> <span class="mf">1.<span class="hl">0</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why has this changed?
AFAIK 1.1 is standardly used.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, one of the problems that happen when code is not only refactored but random things change (AKA this or indentation).
I changed it to 1.1</pre>
<br />
<p>- Aleix</p>
<br />
<p>On January 14th, 2013, 4:02 a.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Jan. 14, 2013, 4:02 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've wanted to use this plasmoid for longtime, I fear that the reason why I'm not using it yet is because I can't start chats from there. The plan is that this will improve the situation, to some extent.
The important part about the patch is that the root element is refactored into a grid that can have different elements. Now I added a button with a contactlist that probably should go, but eventually i'd like to have non-conversation buttons so that one can pin contacts.
** This is the plasmoid part after the split. You can follow the discussion in https://git.reviewboard.kde.org/r/107811/ **</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>chat/org.kde.ktp-chat/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml <span style="color: grey">(818d93f)</span></li>
<li>chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml <span style="color: grey">(8a8d851)</span></li>
<li>chat/org.kde.ktp-chat/contents/ui/ConversationDelegateButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>chat/org.kde.ktp-chat/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108402/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>