Google code in: ktp-text-ui bug 282518

[David Edmundson]

Huba,

That looks pretty good.  I've marked this as complete, because of the
code-in deadline.

However I need to put it to our full team (CC'd) for a full peer
review before we merge it.

Thanks

David Edmundson

On Fri, Jan 11, 2013 at 12:42 AM, HubaNagy <12huba at gmail.com> wrote:
> Hello,
>
> So here is the new patch, with minimal copy-paste. I had some problem with
> the melange thing, even though the status was "needs more work" there was no
> place to upload new files. It said "Click on mark as complete to upload a
> new file", so I did but now its status is needs review, with the wrong
> patch... So here is the right one.
>
> Huba,
>
>
> On Wed, Dec 5, 2012 at 10:12 PM, HubaNagy <12huba at gmail.com> wrote:
>>
>> Oh... I see now. Hmmm...
>>
>> Is it possible to indirectly inherit from KCModule?
>>
>> i.e. QWidget<-KCModule<-AppearanceConfig<-GroupAppearanceConfig,
>> SingleAppearanceConfig
>>
>> Let AppearanceConfig take care of all of the slots and events(with minor
>> modifications) from KCModule and only export the GroupAppearanceConfig and
>> the SingleAppearanceConfig classes as plugins which can be added to the
>> KSettings::Dialog. Making two separate plugins would be the same copy paste
>> thing again.
>>
>> On Dec 5, 2012 8:35 AM, "David Edmundson" <david at davidedmundson.co.uk>
>> wrote:
>>>
>>> I read your patch, I guess I didn't make this very clear in the
>>> description.
>>>
>>> What we want is in the configuration where the user selects the theme
>>> to have 2 tabs . One for normal chats, one for group chats. So in the
>>> config file we have two groups, one with the saved options for normal
>>> chats, one with the saved options for group chats.
>>>
>>> The main text-ui then selects the appropriate theme.
>>>
>>> Thanks for the work so far!
>>>
>>> David
>>>
>>> On Tue, Dec 4, 2012 at 3:01 AM, HubaNagy <12huba at gmail.com> wrote:
>>> > I've uploaded the patch to melange.
>>> >
>>> > 5 deletions and two additions. I spent most of the time looking for a
>>> > reason
>>> > why it might have been hardcoded, is there a specific one? Also I
>>> > haven't
>>> > removed the chatType argument I don't want to screw up anything
>>> > elsewhere.
>>> > Should I do that?
>>> >
>>> > Huba
>>> >
>>> >
>>> > On Tue, Dec 4, 2012 at 5:00 AM, David Edmundson
>>> > <david at davidedmundson.co.uk>
>>> > wrote:
>>> >>
>>> >> You need to upload something to melange otherwise it won't let you
>>> >> mark something as complete.
>>> >>
>>> >> As you're clearly familiar with git,  Use "git format-patch
>>> >> origin/master". Then upload the files it generates.
>>> >> It is not a problem that you need to restart the text-ui, as that bug
>>> >> already exists.
>>> >>
>>> >> I look forward to your patch. Thanks!
>>> >>
>>> >> Dave
>>> >>
>>> >> On Sun, Dec 2, 2012 at 11:35 PM, HubaNagy <12huba at gmail.com> wrote:
>>> >> > Hi,
>>> >> >
>>> >> > would it be alright if I put my branch with the patch on github and
>>> >> > send
>>> >> > you
>>> >> > the link instead of uploading it to melange? Or would you rather
>>> >> > have it
>>> >> > in
>>> >> > an archive?
>>> >> >
>>> >> > Also another problem is, that when you apply the settings you have
>>> >> > to
>>> >> > restart the text ui to force the adium-theme-view to reload the
>>> >> > style.
>>> >> >
>>> >> >
>>> >> > On Sun, Dec 2, 2012 at 10:08 AM, HubaNagy <12huba at gmail.com> wrote:
>>> >> >>
>>> >> >> That's a new error, before I never actually got as far as
>>> >> >> encountering
>>> >> >> the
>>> >> >> second one. The first one I got while compiling tp qt with the
>>> >> >> tests,
>>> >> >> which
>>> >> >> works without compiling the tests. so disabling tests in tp qt
>>> >> >> solved
>>> >> >> this
>>> >> >> problem and after I installed it there were no more errors with tp
>>> >> >> qt.
>>> >> >> Then
>>> >> >> there was something wrong with tpl qt while compiling ktp text ui,
>>> >> >> so I
>>> >> >> commented out the add_subdirectory(logviewer) which temporarily
>>> >> >> solved
>>> >> >> the
>>> >> >> problem, but now I put it back in after installing tpl qt and the
>>> >> >> whole
>>> >> >> thing compiles no problem. First I installed tpl qt from the ubuntu
>>> >> >> repo,
>>> >> >> but that obviously wasn't the right package so I built it from
>>> >> >> source.
>>> >> >> The
>>> >> >> git repo was git://anongit.kde.org/telepathy-logger-qt .
>>> >> >>
>>> >> >> Yes of course I have claimed the task, at least it says It's status
>>> >> >> is
>>> >> >> claimed now.
>>> >> >>
>>> >> >> Cheers
>>> >> >>
>>> >> >>
>>> >> >> On Sun, Dec 2, 2012 at 7:26 AM, David Edmundson
>>> >> >> <david at davidedmundson.co.uk> wrote:
>>> >> >>>
>>> >> >>> Are you sure the error was about TpQt and not actually about
>>> >> >>> TpQtLogger which is different.
>>> >> >>>
>>> >> >>> teleapthy-logger-qt can be installed from
>>> >> >>>
>>> >> >>>
>>> >> >>>
>>> >> >>> https://projects.kde.org/projects/extragear/network/telepathy/telepathy-logger-qt
>>> >> >>>
>>> >> >>> I think your error message may have changed and you not noticed it
>>> >> >>> :)
>>> >> >>> Anyway, glad it's compiling. Have you claimed the task in Melange?
>>> >> >>>
>>> >> >>> Dave
>>> >> >>
>>> >> >>
>>> >> >>
>>> >> >>
>>> >> >> --
>>> >> >> huba
>>> >> >
>>> >> >
>>> >> >
>>> >> >
>>> >> > --
>>> >> > huba
>>> >
>>> >
>>> >
>>> >
>>> > --
>>> > huba
>
>
>
>
> --
> huba
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Allows-the-user-to-set-different-styles-for-one-on-o.patch
Type: application/octet-stream
Size: 35848 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130114/969140ac/attachment-0001.obj>