Review Request: Make it possible to start conversations from the Quick Chat plasmoid

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107811/
-----------------------------------------------------------

(Updated Jan. 10, 2013, 1:41 a.m.)


Review request for Telepathy and David Edmundson.


Changes
-------

Solved most David's concerns. :)


Description
-------

I've wanted to use this plasmoid for longtime, I fear that the reason why I'm not using it yet is because I can't start chats from there. The plan is that this will improve the situation, to some extent.

The important part about the patch is that the root element is refactored into a grid that can have different elements. Now I added a button with a contactlist that probably should go, but eventually i'd like to have non-conversation buttons so that one can pin contacts.


Diffs (updated)
-----

  plasmoid/declarative-plugin/CMakeLists.txt 48ba8a7 
  plasmoid/declarative-plugin/contact-pin.h PRE-CREATION 
  plasmoid/declarative-plugin/contact-pin.cpp PRE-CREATION 
  plasmoid/declarative-plugin/conversation-target.h cd45f2d 
  plasmoid/declarative-plugin/conversation-target.cpp f9c285d 
  plasmoid/declarative-plugin/conversation.h 6eeab86 
  plasmoid/declarative-plugin/conversation.cpp 152d940 
  plasmoid/declarative-plugin/conversations-model.h f9dc047 
  plasmoid/declarative-plugin/conversations-model.cpp faaa60b 
  plasmoid/declarative-plugin/ktp-metatypes.h PRE-CREATION 
  plasmoid/declarative-plugin/messages-model.h 233bbfb 
  plasmoid/declarative-plugin/messages-model.cpp a33b3c4 
  plasmoid/declarative-plugin/pinned-contacts-model.h PRE-CREATION 
  plasmoid/declarative-plugin/pinned-contacts-model.cpp PRE-CREATION 
  plasmoid/declarative-plugin/qml-plugins.cpp 23a4291 
  plasmoid/declarative-plugin/telepathy-text-observer.h 241febb 
  plasmoid/declarative-plugin/telepathy-text-observer.cpp 98dfced 
  plasmoid/org.kde.ktp-chatplasmoid/contents/config/main.xml PRE-CREATION 
  plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml ea68f41 
  plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ContactList.qml PRE-CREATION 
  plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegate.qml 8a8d851 
  plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegateButton.qml PRE-CREATION 
  plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml feb766b 

Diff: http://git.reviewboard.kde.org/r/107811/diff/


Testing
-------

Very little, mostly sending this review for starting a discussion on where we'd like to go with this plasmoid.


Screenshots
-----------

i am pinned
  http://git.reviewboard.kde.org/r/107811/s/952/
pin me
  http://git.reviewboard.kde.org/r/107811/s/953/


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130110/7a401187/attachment.html>