Review Request: Fix height for local-xmpp list view

Daniele E. Domenichelli daniele.domenichelli at gmail.com
Fri Jan 4 11:06:35 UTC 2013



> On Jan. 4, 2013, 10:15 a.m., Martin Klapetek wrote:
> > I'm not seeing this problem. What font size are you using?

Unfortunately this doesn't fix the problem...
The real problem is related to the font size and the size of the icon (try setting a smaller size for the general font to check it)
I think that the delegate size is not calculated correctly if the icon size is greater than the 2 text lines


- Daniele E.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108153/#review24645
-----------------------------------------------------------


On Jan. 4, 2013, 8:36 a.m., Stefan Eggers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108153/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2013, 8:36 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fix height for local-xmpp list view
> 
> The list item was slightly smaller than the containing list view.
> When it was selected there was a small strip below which didn't belong
> to the item and didn't change color. Fixed this.
> 
> 
> This addresses bug 309050.
>     http://bugs.kde.org/show_bug.cgi?id=309050
> 
> 
> Diffs
> -----
> 
>   src/main-widget.ui 4983c71c4d7d183525dd705fc5859f38d1f64d0b 
> 
> Diff: http://git.reviewboard.kde.org/r/108153/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stefan Eggers
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130104/4296ae13/attachment.html>


More information about the KDE-Telepathy mailing list