Review Request: Make it possible to start conversations from the Quick Chat plasmoid

[Aleix Pol Gonzalez]

> On Jan. 2, 2013, 9:56 p.m., Thomas Pfeiffer wrote:
> > Here are my comments from a UX perspective:
> > 
> > The pin feature is definitely useful for quick access to people you chat with most. I would not put a seperate contact list for the sole purpose of pinning contacts in the chat plasmoid, though. It would make more sense to me to just add a pin button to the contact list Plasmoid (in addition to a "start chat" button) as soon as it supports action buttons (see https://bugs.kde.org/show_bug.cgi?id=303729 for details)
> > 
> > So, in short, my suggestion: Implement the pin/unpin button in the chat popup, but not the contact list button. Put that in the re-designed contact list plasmoid as an action button instead. And release the modification only when the new contact list Plasmoid is done, so that users won't have a half-working feature

I completely agree. I was thinking about that too.

I'll remove the contact list button in the next iteration of the plugin. I think that we should be able to open chats in the plasmoid (if available) from the other contact lists...

David?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107811/#review24515
-----------------------------------------------------------


On Jan. 2, 2013, 5:34 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107811/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2013, 5:34 p.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> I've wanted to use this plasmoid for longtime, I fear that the reason why I'm not using it yet is because I can't start chats from there. The plan is that this will improve the situation, to some extent.
> 
> The important part about the patch is that the root element is refactored into a grid that can have different elements. Now I added a button with a contactlist that probably should go, but eventually i'd like to have non-conversation buttons so that one can pin contacts.
> 
> 
> Diffs
> -----
> 
>   plasmoid/declarative-plugin/CMakeLists.txt 48ba8a7 
>   plasmoid/declarative-plugin/contactpin.h PRE-CREATION 
>   plasmoid/declarative-plugin/contactpin.cpp PRE-CREATION 
>   plasmoid/declarative-plugin/conversation-target.h cd45f2d 
>   plasmoid/declarative-plugin/conversation-target.cpp f9c285d 
>   plasmoid/declarative-plugin/conversation.h 6eeab86 
>   plasmoid/declarative-plugin/conversation.cpp 152d940 
>   plasmoid/declarative-plugin/conversations-model.h f9dc047 
>   plasmoid/declarative-plugin/conversations-model.cpp faaa60b 
>   plasmoid/declarative-plugin/ktp-metatypes.h PRE-CREATION 
>   plasmoid/declarative-plugin/pinnedcontactsmodel.h PRE-CREATION 
>   plasmoid/declarative-plugin/pinnedcontactsmodel.cpp PRE-CREATION 
>   plasmoid/declarative-plugin/qml-plugins.cpp 23a4291 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml ea68f41 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ContactList.qml PRE-CREATION 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegate.qml 8a8d851 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegateButton.qml PRE-CREATION 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml feb766b 
> 
> Diff: http://git.reviewboard.kde.org/r/107811/diff/
> 
> 
> Testing
> -------
> 
> Very little, mostly sending this review for starting a discussion on where we'd like to go with this plasmoid.
> 
> 
> Screenshots
> -----------
> 
> i am pinned
>   http://git.reviewboard.kde.org/r/107811/s/952/
> pin me
>   http://git.reviewboard.kde.org/r/107811/s/953/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130103/670c4889/attachment.html>