<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107811/">http://git.reviewboard.kde.org/r/107811/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 2nd, 2013, 9:56 p.m., <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Here are my comments from a UX perspective:
The pin feature is definitely useful for quick access to people you chat with most. I would not put a seperate contact list for the sole purpose of pinning contacts in the chat plasmoid, though. It would make more sense to me to just add a pin button to the contact list Plasmoid (in addition to a "start chat" button) as soon as it supports action buttons (see https://bugs.kde.org/show_bug.cgi?id=303729 for details)
So, in short, my suggestion: Implement the pin/unpin button in the chat popup, but not the contact list button. Put that in the re-designed contact list plasmoid as an action button instead. And release the modification only when the new contact list Plasmoid is done, so that users won't have a half-working feature</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I completely agree. I was thinking about that too.
I'll remove the contact list button in the next iteration of the plugin. I think that we should be able to open chats in the plasmoid (if available) from the other contact lists...
David?</pre>
<br />
<p>- Aleix</p>
<br />
<p>On January 2nd, 2013, 5:34 p.m., Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Jan. 2, 2013, 5:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've wanted to use this plasmoid for longtime, I fear that the reason why I'm not using it yet is because I can't start chats from there. The plan is that this will improve the situation, to some extent.
The important part about the patch is that the root element is refactored into a grid that can have different elements. Now I added a button with a contactlist that probably should go, but eventually i'd like to have non-conversation buttons so that one can pin contacts.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Very little, mostly sending this review for starting a discussion on where we'd like to go with this plasmoid.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmoid/declarative-plugin/CMakeLists.txt <span style="color: grey">(48ba8a7)</span></li>
<li>plasmoid/declarative-plugin/contactpin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/declarative-plugin/contactpin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/declarative-plugin/conversation-target.h <span style="color: grey">(cd45f2d)</span></li>
<li>plasmoid/declarative-plugin/conversation-target.cpp <span style="color: grey">(f9c285d)</span></li>
<li>plasmoid/declarative-plugin/conversation.h <span style="color: grey">(6eeab86)</span></li>
<li>plasmoid/declarative-plugin/conversation.cpp <span style="color: grey">(152d940)</span></li>
<li>plasmoid/declarative-plugin/conversations-model.h <span style="color: grey">(f9dc047)</span></li>
<li>plasmoid/declarative-plugin/conversations-model.cpp <span style="color: grey">(faaa60b)</span></li>
<li>plasmoid/declarative-plugin/ktp-metatypes.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/declarative-plugin/pinnedcontactsmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/declarative-plugin/pinnedcontactsmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/declarative-plugin/qml-plugins.cpp <span style="color: grey">(23a4291)</span></li>
<li>plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml <span style="color: grey">(ea68f41)</span></li>
<li>plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ContactList.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegate.qml <span style="color: grey">(8a8d851)</span></li>
<li>plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegateButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml <span style="color: grey">(feb766b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107811/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107811/s/952/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/02/ktp-pinned_400x100.png" style="border: 1px black solid;" alt="i am pinned" /></a>
<a href="http://git.reviewboard.kde.org/r/107811/s/953/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/02/ktp-pinned1_400x100.png" style="border: 1px black solid;" alt="pin me" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>