Review Request 109161: Update Highlight filter

[Stefan Eggers]

> On Feb. 26, 2013, 7:44 a.m., Martin Klapetek wrote:
> > filters/highlight/highlight-filter.cpp, lines 35-36
> > <http://git.reviewboard.kde.org/r/109161/diff/2/?file=115629#file115629line35>
> >
> >     Var name here too. Also the d(new..) is usually on a new line.
> 
> Lasath Fernando wrote:
>     If I put the variable name there, we will get a warning saying "unused variable".

Q_UNUSED() should suppress these warnings. See for example ktp-text-ui/filters/emoticons/emoticon-filter.cpp in method EmoticonFilter::filterMessage.


- Stefan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109161/#review28103
-----------------------------------------------------------


On Feb. 26, 2013, 3:52 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109161/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2013, 3:52 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This one was fairly straight forward. Just had to fix some build issues and update the metadata file.
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt ac25a17 
>   filters/highlight/CMakeLists.txt PRE-CREATION 
>   filters/highlight/highlight-filter.h PRE-CREATION 
>   filters/highlight/highlight-filter.cpp PRE-CREATION 
>   filters/highlight/ktptextui_message_filter_highlight.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109161/diff/
> 
> 
> Testing
> -------
> 
> Wrote my name. Felt like in primary school.
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130226/699a3916/attachment-0001.html>