Review Request 109161: Update Highlight filter

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109161/#review28119
-----------------------------------------------------------

Ship it!


OK, I've seen what happened last time we left a review open for too long.

Fix Martin's comments, and you can ship it. 

I might disable the enabled-by-default until we fix the notifications though.

- David Edmundson


On Feb. 26, 2013, 3:52 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109161/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2013, 3:52 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This one was fairly straight forward. Just had to fix some build issues and update the metadata file.
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt ac25a17 
>   filters/highlight/CMakeLists.txt PRE-CREATION 
>   filters/highlight/highlight-filter.h PRE-CREATION 
>   filters/highlight/highlight-filter.cpp PRE-CREATION 
>   filters/highlight/ktptextui_message_filter_highlight.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109161/diff/
> 
> 
> Testing
> -------
> 
> Wrote my name. Felt like in primary school.
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130226/fa2d76dc/attachment.html>