Review Request 109137: Proper filtering for pinned contacts

Aleix Pol Gonzalez aleixpol at gmail.com
Mon Feb 25 14:35:05 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109137/
-----------------------------------------------------------

(Updated Feb. 25, 2013, 2:35 p.m.)


Review request for Telepathy and David Edmundson.


Changes
-------

With setDynamicSortFilter(true) it listens to dataChanged, then it works.


Description
-------

This adds a new class to substitute the:
visible: available && !alreadyChatting

For some reason it's not responding to the dataChanged when alreadyChatting changes, though. Does anybody know why?


Diffs (updated)
-----

  KTp/Declarative/CMakeLists.txt f42252d 
  KTp/Declarative/filtered-pinned-contacts-proxy-model.h PRE-CREATION 
  KTp/Declarative/filtered-pinned-contacts-proxy-model.cpp PRE-CREATION 
  KTp/Declarative/qml-plugins.cpp bd2a927 

Diff: http://git.reviewboard.kde.org/r/109137/diff/


Testing
-------


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130225/796e9314/attachment.html>


More information about the KDE-Telepathy mailing list