Review Request 109137: Proper filtering for pinned contacts

[Aleix Pol Gonzalez]

> On Feb. 25, 2013, 2:20 p.m., David Edmundson wrote:
> > KTp/Declarative/qml-plugins.cpp, line 47
> > <http://git.reviewboard.kde.org/r/109137/diff/1/?file=115294#file115294line47>
> >
> >     I wonder if we should stop exposing the PinnedContactModel and instead hardcode the sourceModel into the proxy model.
> >     
> >     It'd make the QML easier. Thoughts?

I like it like that. It's easy to see where things come from and we don't need to do any property forwarding.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109137/#review28026
-----------------------------------------------------------


On Feb. 25, 2013, 5:21 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109137/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 5:21 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> This adds a new class to substitute the:
> visible: available && !alreadyChatting
> 
> For some reason it's not responding to the dataChanged when alreadyChatting changes, though. Does anybody know why?
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/qml-plugins.cpp bd2a927 
>   KTp/Declarative/CMakeLists.txt f42252d 
>   KTp/Declarative/filtered-pinned-contacts-proxy-model.h PRE-CREATION 
>   KTp/Declarative/filtered-pinned-contacts-proxy-model.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109137/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130225/588af67e/attachment-0001.html>